Skip to content

Conversation

@istarkov
Copy link
Member

@istarkov istarkov commented Nov 4, 2024

Description

closes #3715

Steps for reproduction

paste in chrome
view-source:https://webstudio-fixture-project-a-0su3o.wstd.work/sitemap.xml

See title tag exists

image

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov merged commit 11c65dc into main Nov 4, 2024
27 checks passed
@istarkov istarkov deleted the xml-title.staging branch November 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML Node with title tag nested in any other XML Node breaks document

3 participants